Skip to content

Conversation

@existentialcoder
Copy link
Contributor

@existentialcoder existentialcoder commented Jan 8, 2026

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Personal
image
Group
image |

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@existentialcoder existentialcoder changed the title Iss 16659 feat(message-expiry): Add message expiry msg on the right side bar Jan 8, 2026
@existentialcoder
Copy link
Contributor Author

@Antreesy Apologies for the delay.

Addressed review comments on the latest commit and updated the screenshots in the description. Request to re-review

import { showMessage } from '@nextcloud/dialogs'
import { emit, subscribe, unsubscribe } from '@nextcloud/event-bus'
import { t } from '@nextcloud/l10n'
import { getCanonicalLocale, t } from '@nextcloud/l10n'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all remaining changes from previous commits

background-color: var(--color-primary-element);
pointer-events: none;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And all changes that are not related to the feature

:color="event.color" />
</ul>
</div>
<div v-if="isMessageExpirationSet" class="message-expiration">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected it to be a part of profileInformation, so the line has consistent styles with other information:

Current Expected
Image Image
Image Image
Image Image

This should be enough:

	if (conversation.value.messageExpiration > 0) {
		const duration = defaultExpirationOptions.find(({ id }) => conversation.value.messageExpiration === id)?.label
			?? t('spreed', 'Custom expiration time')

		fields.push({
			key: 'expiration',
			icon: IconDeleteClockOutline,
			label: t('spreed', 'Message expiration set: {duration}', { duration }),
		})
	}

Copy link
Contributor Author

@existentialcoder existentialcoder Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya But this doesnt show up in group conversation sidebar cause the profileInformation is null. Do you want separate blocks to handle group and 1-1?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's happening because of early return in this function and template (checking profileInfo.value === null, these could be removed or adjusted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes right!

@Antreesy
Copy link
Contributor

Almost good to go! Please squash your commit into one, and sign it off (see red CI check for DCO for more information)

@existentialcoder existentialcoder force-pushed the iss-16659 branch 2 times, most recently from 152d956 to 915e569 Compare January 13, 2026 18:40
@existentialcoder
Copy link
Contributor Author

Almost good to go! Please squash your commit into one, and sign it off (see red CI check for DCO for more information)

Hope its good to go. Let me know

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chat should permanently indicate whether message expiration is set up

3 participants